changefeedccl: change db-level feed default to no initial scan #158104
Conversation
|
This change is |
aerfrei
force-pushed
the
db-level-feeds-no-initial-scan-by-default
branch
4 times, most recently
from
dd5ef63 to
10a5244
Compare
| `foo: [0]->{"after": {"a": 0, "b": "initial"}}`, | ||
| `bar: [1]->{"after": {"a": 1, "b": "initial"}}`, | ||
| }) | ||
| // Database level changefeeds do not perform an initial scan. |
There was a problem hiding this comment.
You can probably remove this unless we explicitly check that the payload doesn't exist.
There was a problem hiding this comment.
Do you mean to remove the comment or not to add the rows in the first place? FWIW, we do check them for the table level feed that is started in this test.
I'm not sure adding the rows adds so much to the test, but I don't think it hurts. And if we keep it around, I think it's worth keeping the comment to explain the difference.
There was a problem hiding this comment.
I updated the comment to make this clearer. I guess I could also just explicitly specify WITH initial_scan='yes' for the db-level changefeed.
There was a problem hiding this comment.
I meant remove the comment
aerfrei
force-pushed
the
db-level-feeds-no-initial-scan-by-default
branch
from
10a5244 to
a3a7c8c
Compare
This change the default initial scan behavior for db-level feeds to not do an initial scan if no option is specified. When an initial scan is specified, that is respected. We do not allow db-level changefeeds with initial_scan='only'. This includes a rewrite of existing db-level feeds tests which rely on default initial scans in their testing. Epic: CRDB-1421 Informs: cockroachdb#156484 Release note: None
aerfrei
force-pushed
the
db-level-feeds-no-initial-scan-by-default
branch
from
a3a7c8c to
aa79556
Compare
|
TFTR! bors r=KeithCh,asg0451 |
4 participants
This change the default initial scan behavior for db-level feeds to not do an initial scan if no option is specified. When an option is specified for initial scan, it is respected.
This includes a rewrite of existing db-level feeds tests which rely on default initial scans in their testing.
Epic: CRDB-1421
Informs: #156484
Release note: None